Conversation
…ts, some more documentation improvements
…and Array conversions for FEVector
pjaap
reviewed
Jun 26, 2025
Member
pjaap
left a comment
pjaap
left a comment
There was a problem hiding this comment.
Nice. The new doc strings seem reasonable to me. I can imagine that some details will be strange when I actually need the precise documentation of a certain method. But this fine tuning can be done later.
And see the one comment about the kwargs
| if nodes == [] | ||
| if cellwise | ||
| target = zeros(T, nvals * max_num_targets_per_source(source.FES.dofgrid[CellNodes]), num_cells(source.FES.dofgrid)) | ||
| piecewise_nodevalues!(target, source.entries, source.FES, operator; continuous = continuous, source_offset = source.offset, abs = abs, kwargs...) |
Member
There was a problem hiding this comment.
The kwargs continuous and source_offset are omitted here. Is this intended?
Also in 2 lines below.
Member
Author
There was a problem hiding this comment.
piecewise_nodevalues! does not use continuous, but ommiting the source_offset is a mistake, this needs to be readded. Thanks for spotting this!
pjaap
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I played around with github copilot and let it suggest improvements to docstrings, show function, documentation files and some constructors. After some edits, the results are a huge improvement, I think.